[bisq-network/bisq] Add support for user name for Revolut accounts (#4453)

[chimp1984]

@chimp1984 commented on this pull request.



> @@ -17,10 +17,13 @@
 
 package bisq.desktop.util.validation;
 
-public final class RevolutValidator extends PhoneNumberValidator {
+public final class RevolutValidator extends LengthValidator {

We have to consider that even the app forces users to set userName now at startup we should not cause bigger problems if the phone number or email is used (via getuserName). Not sure if validator is used in such a potential use case, but not worth to make usage of the account impossible just because of a more strict validator. Also requirements at Revolut might change and our validation would fail then. I think we should not have a close dependency on that. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4453#discussion_r481239325
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200901/ffc8e2de/attachment.html>