[bisq-network/bisq] Make CoreApi a singleton (#4461)

[Stan]

This PR ensures a daemon never creates more than one `CoreApi` instance, but two additional, minor changes are included:

 * Add `@VisibleForTesting` annotation to `CompositeOptionSet` to explain why it is no longer package protected.

 *  Remove commented code from `BisqAppMain`.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4461

-- Commit Summary --

  * Make CoreApi a singleton
  * Add @VisibleForTesting annotation
  * Remove commented code from BisqAppMain

-- File Changes --

    M common/src/main/java/bisq/common/config/CompositeOptionSet.java (3)
    M core/src/main/java/bisq/core/api/CoreApi.java (2)
    M desktop/src/main/java/bisq/desktop/app/BisqAppMain.java (14)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4461.patch
https://github.com/bisq-network/bisq/pull/4461.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4461
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200901/760338eb/attachment.html>