[bisq-network/bisq] Register dispute agents in apitest arbitrator daemon (#4462)

[Stan]

This PR adds a new `CoreDisputeAgentService` for handling dispute agent registration in arbitrator daemons.  API methods for dispute agent registration in `mainnet` mode are out of scope of this PR;  these changes are for supporting the auto-registration of a mediator and refund agent in `regtest/dao` mode for `apitest` cases.  

Some minor, unrelated changes are included, and listed below.

 * Inject new `CoreDisputeAgentService` into `CoreApi`.

 * Change a `DisputeAgentManager` 'dispute agent saved' log statement to indicate type of agent being saved.

 * Add `import static bisq.common.app.Version.VERSION` to `CoreApi`, and add `@SuppressWarnings("SameReturnValue")` annotation to the `getVersion` method.

 * Fix comment in `Scaffold` class.

[PR 4461](https://github.com/bisq-network/bisq/pull/4461) should be reviewed/merged before this one.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4462

-- Commit Summary --

  * Make CoreApi a singleton
  * Add @VisibleForTesting annotation
  * Remove commented code from BisqAppMain
  * Register dispute agents in apitest arbitrator daemon

-- File Changes --

    M apitest/src/main/java/bisq/apitest/Scaffold.java (2)
    M common/src/main/java/bisq/common/config/CompositeOptionSet.java (3)
    M core/src/main/java/bisq/core/api/CoreApi.java (15)
    A core/src/main/java/bisq/core/api/CoreDisputeAgentService.java (171)
    M core/src/main/java/bisq/core/support/dispute/agent/DisputeAgentManager.java (2)
    M desktop/src/main/java/bisq/desktop/app/BisqAppMain.java (14)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4462.patch
https://github.com/bisq-network/bisq/pull/4462.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4462
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200901/7e96421c/attachment-0001.html>