[bisq-network/bisq] Register dispute agents in apitest arbitrator daemon (#4462)

[sqrrm]

@sqrrm commented on this pull request.



> +        this.keyRing = keyRing;
+        this.mediatorManager = mediatorManager;
+        this.refundAgentManager = refundAgentManager;
+        this.p2PService = p2PService;
+        setupListeners();
+    }
+
+    public Optional<Mediator> getMediator(NodeAddress nodeAddress) {
+        return mediatorManager.getDisputeAgentByNodeAddress(nodeAddress);
+    }
+
+    public Optional<RefundAgent> getRefundAgent(NodeAddress nodeAddress) {
+        return refundAgentManager.getDisputeAgentByNodeAddress(nodeAddress);
+    }
+
+    private boolean shouldRegisterTestArbitrationDisputeAgents() {

I don't think we should allow mainnet registration of dispute agent via cli for now. There are a lot of very specific dispute handling that I think is handled on the UI side. A UI of some sort would also be needed since it's a human facing role that's done manually.

For testing it's fine to have an automatically registered agent of course. Still would prefer if the test specifics were moved to the tests package.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4462#discussion_r482512398
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200902/b4387a86/attachment.html>