[bisq-network/bisq] Register dispute agents in apitest arbitrator daemon (#4462)

Stan notifications at github.com
Wed Sep 2 23:00:52 UTC 2020


@ghubstan commented on this pull request.



> +        this.keyRing = keyRing;
+        this.mediatorManager = mediatorManager;
+        this.refundAgentManager = refundAgentManager;
+        this.p2PService = p2PService;
+        setupListeners();
+    }
+
+    public Optional<Mediator> getMediator(NodeAddress nodeAddress) {
+        return mediatorManager.getDisputeAgentByNodeAddress(nodeAddress);
+    }
+
+    public Optional<RefundAgent> getRefundAgent(NodeAddress nodeAddress) {
+        return refundAgentManager.getDisputeAgentByNodeAddress(nodeAddress);
+    }
+
+    private boolean shouldRegisterTestArbitrationDisputeAgents() {

How about a new API method `registerdisputeagent [dispute-agent-type]` that does not work on mainnet?  It would throw an exception to a mainnet CLI, and the user would see an `Error: dispute agents must be registered in the Bisq UI` msg.

Headless regtest api test cases could use this method.

Sound OK?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4462#discussion_r482579330
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200902/b513b7ea/attachment.html>


More information about the bisq-github mailing list