[bisq-network/proposals] Integrate transaction proof verification for Monero (#86)

chimp1984 notifications at github.com
Wed Sep 2 23:46:57 UTC 2020


@moneroexamples 
We have implemented the auto-confirmation with the tx proof (https://github.com/bisq-network/bisq/pull/4458) and at testing with an old xmr transaction I got a different address in the json as we would expect with the converted user address.

We use that code for conversion (author: @jmacxx )

```
  byte[] decoded = MoneroBase58.decode(address);
            // omit the type (1st byte) and checksum (last 4 byte)
            byte[] slice = Arrays.copyOfRange(decoded, 1, decoded.length - 4);
            return Utils.HEX.encode(slice);
```

```
Address from json result (convertToRawHex):
8c23cc40c40f01c5c6d8ed10d2f1707f7b855ba37f535c01f80664a3b257bf7eebba21399be830c6435e5cd2edc3b374cf40b949018ea2004205694a5400bbae
Expected (convertToRawHex):
8c23cc40c40f01c5c6d8ed10d2f1707f7b855ba37f535c01f80664a3b257bf7eebba21399be830c6435e5cd2edc3b374cf40b949018ea2004205694a5400bbae190200fd2c2d887a 
```

So the expected value from our address conversion has 8 bytes at the end more than the address in the json. Is it related to the address format change? This tx was nearly 1 year old.

Any idea whats the reason for the problem and how to fix it? Sorry I am not much familiar with internals of Monero.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/86#issuecomment-686119295
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200902/19c51416/attachment-0001.html>


More information about the bisq-github mailing list