[bisq-network/bisq] Use InetAddress.getLoopbackAddress instead of InetAddress.getLocalHost() (#4466)

[chimp1984]

On OSX InetAddress.getLocalHost() can cause problems. On my machine I
get a 5 sec. delay at each start up in localhost mode. The
InetAddress.getLoopbackAddress call is super fast.

Both versions connect to my local btc node, but not sure what can be
the differences if local environment is configured differently as
default. But as those issues with very slow getLocalHost lookup seems
to be more risky I would recommend that we change it.

It only affects localhost regtest mode and users who have a local btc
node running. The detection code for that is using getLoopbackAddress
as well.
See: https://github.com/bisq-network/bisq/pull/4373/commits/a5cca0ee1e63089b9a5a0d8b2793e31006499288

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4466

-- Commit Summary --

  * Use InetAddress.getLoopbackAddress instead of InetAddress.getLocalHost()

-- File Changes --

    M core/src/main/java/bisq/core/btc/setup/WalletConfig.java (10)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4466.patch
https://github.com/bisq-network/bisq/pull/4466.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4466
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200902/5434134a/attachment.html>