[bisq-network/bisq] Remove USE_DEV_MODE_HEADER option (#4473)

chimp1984 notifications at github.com
Thu Sep 3 18:04:42 UTC 2020


@sqrrm I leave it to you if we remove it or not. But if we leave it please fix that the isDevMode gets overwritten if the new flag is not set.
IMO we dont need an additional flag. See https://github.com/bisq-network/bisq/pull/4471 as well which should help
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4473

-- Commit Summary --

  * Remove USE_DEV_MODE_HEADER option

-- File Changes --

    M common/src/main/java/bisq/common/config/Config.java (10)
    M core/src/main/java/bisq/core/app/BisqExecutable.java (1)
    M core/src/main/java/bisq/core/app/CoreModule.java (1)
    M core/src/main/java/bisq/core/app/misc/ModuleForAppWithP2p.java (1)
    M desktop/src/main/java/bisq/desktop/app/BisqApp.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java (8)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4473.patch
https://github.com/bisq-network/bisq/pull/4473.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4473
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200903/d06de93d/attachment.html>


More information about the bisq-github mailing list