[bisq-network/bisq] Register dispute agents in apitest arbitrator daemon (#4462)

Stan notifications at github.com
Thu Sep 3 22:04:01 UTC 2020


@ghubstan commented on this pull request.



> +        this.keyRing = keyRing;
+        this.mediatorManager = mediatorManager;
+        this.refundAgentManager = refundAgentManager;
+        this.p2PService = p2PService;
+        setupListeners();
+    }
+
+    public Optional<Mediator> getMediator(NodeAddress nodeAddress) {
+        return mediatorManager.getDisputeAgentByNodeAddress(nodeAddress);
+    }
+
+    public Optional<RefundAgent> getRefundAgent(NodeAddress nodeAddress) {
+        return refundAgentManager.getDisputeAgentByNodeAddress(nodeAddress);
+    }
+
+    private boolean shouldRegisterTestArbitrationDisputeAgents() {

The combined 9 commits below is a fix for the weird short cut I took for automatically registering dispute agents in api test cases.  Now it's done over gRPC with a `registerdisputeagent` method that will not work on mainnet.

It required some refactoring in the test harness so api calls could be made to an arbitration daemon, and there are a few other minor changes:  renaming a class, line formatting in the cli, and removing hard coded "localhost" strings.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4462#discussion_r483277943
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200903/c619e77e/attachment.html>


More information about the bisq-github mailing list