[bisq-network/bisq] Improve handling of p2pNetworkAndWalletReady (#4479)

[chimp1984]

The p2pNetworkAndWalletReady MonadicBinding might be removed from GC
if its a local variable. I observed that in BisqSetup with a similar
setup. It might be an implementation weakness in MonadicBinding
(usage of weak references?). A tester reported that he does not see any
result, which might be cause that the service never gets the
onP2pNetworkAndWalletReady triggered if the MonadicBinding is not there
anymore.
By removing the listener we need at shutdown we need it anyway as class
field (so codacy does not complain anymore). As well added a check if
all is already complete to skip the MonadicBinding at all
(not expected case in onAllServicesInitialized).

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4479

-- Commit Summary --

  * Improve handling of p2pNetworkAndWalletReady

-- File Changes --

    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofService.java (38)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4479.patch
https://github.com/bisq-network/bisq/pull/4479.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4479
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200904/ea4cd0f5/attachment-0001.html>