[bisq-network/bisq] Add backward compatibility for revolut change (#4481)

[chimp1984]

New appraoch:

We apply userName to accountId if it is not set (e.g. new account created with new version). We do not use that for display or for account signing in case both fields are the same but we need to use accountId in case the user trades with a not updated user who expects accountId as only field.
I improved a bit the display of account data in the trade screens.
In case accountId was set with the phone number (updated account with phone nr used for account signing) we show both userName and phone nr.

- Show phone number if accountId was set by old account. Otherwise show only userName
- For old users they will see the user name as phone number displayed if they trade with new users if the new user has created a new account. If he has updated an existing account the accountId (phone number) is used, so it displays the phone number.
- At step 2 changed display of own account data to show account name
- Add 'Recipients' prefix to account data of peer at step 2

Step 3: Buyers account data can be
- Phone number if peer is using old version
- User name if peer is updated user with new account (we apply userName to accountId)
- Phone number if user is on old version and peer is updated user with updated account (we keep accountId as phone number)
- User name/Phone number if peer is updated user with updated account

Users/testers who have used master with the new username set, may face unexpected issues. Best is to remove such accounts (if testers). If it happens to traders they can copy salt and create a new account with same phone number with old release version. So the same witness is created for account signing. And then update to master again to set the new user name. 

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4481

-- Commit Summary --

  * Add JsonExclude to userName
  * Add check if xmrTxProof is used to avoid null pointer exception
  * Move revolutAccountsUpdateHandler code up to BisqSetup
  * Fix handling of username/accountId

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqSetup.java (9)
    M core/src/main/java/bisq/core/payment/PaymentAccountUtil.java (9)
    M core/src/main/java/bisq/core/payment/RevolutAccount.java (8)
    M core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java (88)
    M core/src/main/java/bisq/core/user/User.java (12)
    M core/src/main/resources/i18n/displayStrings.properties (4)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/RevolutForm.java (22)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java (72)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4481.patch
https://github.com/bisq-network/bisq/pull/4481.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4481
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200904/bf3f1530/attachment.html>