[bisq-network/bisq] Remove offer from takers offerbook after take offer is completed. (#4487)

chimp1984 notifications at github.com
Sun Sep 6 00:45:51 UTC 2020


We do not wait until the offer got removed by a network remove message but remove it
directly from the offer book. The broadcast gets now bundled and has 2 sec. delay so the
removal from the network is a bit slower as it has been before. To avoid that the taker gets
confused to see the same offer still in the offerbook we remove it manually. This removal has
only local effect. Other trader might see the offer for a few seconds
still (but cannot take it).

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4487

-- Commit Summary --

  * Remove offer from takers offerbook after take offer is completed.

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBook.java (24)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java (17)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4487.patch
https://github.com/bisq-network/bisq/pull/4487.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4487
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200905/ac843f54/attachment-0001.html>


More information about the bisq-github mailing list