[bisq-network/bisq] Add backward compatibility for revolut change (#4481)

chimp1984 notifications at github.com
Sun Sep 6 17:10:10 UTC 2020


@chimp1984 commented on this pull request.



> @@ -105,7 +110,34 @@ public static RevolutAccountPayload fromProto(protobuf.PaymentAccountPayload pro
 
     @Override
     public String getPaymentDetails() {
-        return Res.get(paymentMethodId) + " - " + Res.getWithCol("payment.account.userName") + " " + getUserName();
+        Tuple2<String, String> tuple = getLabelValueTuple();
+        return Res.get(paymentMethodId) + " - " + tuple.first + ": " + tuple.second;
+    }
+
+    private Tuple2<String, String> getLabelValueTuple() {

Yes, not great all those special cases. Could be done mor elegantly for sure but this feature ate already much more time as expected, so tried to get it fixes as quickly I could ;-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4481#discussion_r484093214
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200906/e3b1c665/attachment.html>


More information about the bisq-github mailing list