[bisq-network/bisq] Deactivate confirm buttons once mediation started (#4486)

chimp1984 notifications at github.com
Mon Sep 7 03:58:39 UTC 2020


@chimp1984 commented on this pull request.



> @@ -420,4 +420,14 @@ private void cleanupTradableOnFault() {
             }
         }
     }
+
+    protected boolean wasDisputed(ErrorMessageHandler errorMessageHandler) {
+        if (trade.getDisputeState() != Trade.DisputeState.NO_DISPUTE) {
+            String msg = "Dispute have been opened once. We do not allow anymore to confirm payment by button click.";
+            log.error(msg);

I think that is not too harsh as it is not possible to get there as long a user does not write custom code. Will be also more visible in case the API starts to use those code branches and does not do the checks we do in the UI. Maybe even an exception is justified here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4486#discussion_r484170917
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200906/9fd2c465/attachment-0001.html>


More information about the bisq-github mailing list