[bisq-network/bisq] Use https:// for XMR explorer API endpoints, except if localhost or Tor (#4492)

Stephan Oeste notifications at github.com
Tue Sep 8 14:45:23 UTC 2020


utACK

> Code looks fine to me. Can't say the same for the regexes, but they might well be correct, I can't tell. If I can get another ack for regexes I'm fine with this PR. @Emzy that seems to be your forte :)

The regexes and the networks to be local addresses look right. But I'm not a JAVA dev.
I haven't run the tests, but they also look good.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4492#issuecomment-688926113
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200908/f22133dd/attachment.html>


More information about the bisq-github mailing list