[bisq-network/bisq] Use bisq's bitcoinj 0.15.8 - september 2020 (#4504)

[chimp1984]

@chimp1984 requested changes on this pull request.



> +            new ChildNumber(142, true),
+            ChildNumber.ZERO_HARDENED);
+
+    public static final ImmutableList<ChildNumber> BIP44_BSQ_SEGWIT_ACCOUNT_PATH = ImmutableList.of(
+            new ChildNumber(44, true),
+            new ChildNumber(142, true),
+            ChildNumber.ONE_HARDENED);
+
+    private boolean isBsqWallet;
+
+    public BisqKeyChainGroupStructure (boolean isBsqWallet) {
+        this.isBsqWallet = isBsqWallet;
+    }
+
+    @Override
+    public ImmutableList<ChildNumber> accountPathFor(Script.ScriptType outputScriptType) {

Aren't there more script types (MultiSig) to check?

> @@ -172,7 +172,6 @@ public WalletsSetup(RegTestHost regTestHost,
 
         btcWalletFileName = "bisq_" + config.baseCurrencyNetwork.getCurrencyCode() + ".wallet";
         params = Config.baseCurrencyNetworkParameters();
-        PeerGroup.setIgnoreHttpSeeds(true);

Are httpSeed still used by default in BitcoinJ? If so I would prefer to still make sure to not use http seeds as they have some privacy issues.

> @@ -495,6 +485,8 @@ private Wallet loadWallet(boolean shouldReplayWallet, File walletFile, boolean i
     }
 
     protected Wallet createWallet(boolean isBsqWallet) {
+        // Change preferredOutputScriptType of btc wallet to P2WPKH to start using segwit
+        Script.ScriptType preferredOutputScriptType = isBsqWallet ? Script.ScriptType.P2PKH : Script.ScriptType.P2PKH;

I guess the else case should be P2WPKH

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4504#pullrequestreview-484587743
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200908/bbfd24c9/attachment.html>