[bisq-network/bisq] Add backward compatibility for revolut change (#4481)
Christoph Atteneder
notifications at github.com
Wed Sep 9 14:26:36 UTC 2020
@ripcurlx commented on this pull request.
> + public void setUserName(String userName) {
+ this.userName = userName;
+ // We need to set accountId as pre v1.3.8 clients expect the accountId field
+ if (accountId.isEmpty()) {
+ accountId = userName;
+ }
I just tried to create a new Revolut account and saw that it doesn't behave as expected.
![Bildschirmfoto 2020-09-09 um 16 12 09](https://user-images.githubusercontent.com/170962/92611346-fb2a9e80-f2b8-11ea-95b4-dd9e2dcaef61.png)
![Bildschirmfoto 2020-09-09 um 16 13 35](https://user-images.githubusercontent.com/170962/92611362-fe258f00-f2b8-11ea-8622-50f92e1dfe87.png)
The problem is that it is checked at this place if the accountId is empty which will only work for the first character entered into the field e.g. `B` of `Bobby` this ends up with `accountId` set to `B` and userName set to `Bobby`
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4481#pullrequestreview-485066342
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200909/a33a58bb/attachment.html>
More information about the bisq-github
mailing list