[bisq-network/bisq] Use bisq's bitcoinj 0.15.8 - september 2020 (#4504)

[Oscar Guindzberg]

@oscarguindzberg commented on this pull request.



> +            new ChildNumber(142, true),
+            ChildNumber.ZERO_HARDENED);
+
+    public static final ImmutableList<ChildNumber> BIP44_BSQ_SEGWIT_ACCOUNT_PATH = ImmutableList.of(
+            new ChildNumber(44, true),
+            new ChildNumber(142, true),
+            ChildNumber.ONE_HARDENED);
+
+    private boolean isBsqWallet;
+
+    public BisqKeyChainGroupStructure (boolean isBsqWallet) {
+        this.isBsqWallet = isBsqWallet;
+    }
+
+    @Override
+    public ImmutableList<ChildNumber> accountPathFor(Script.ScriptType outputScriptType) {

Even though Bisq uses multisig (eg for payout tx signing), bisq does not use a multisig keychain.
A multisig keychain (MarriedKeyChain in bitcoinj) makes sense when you want to repeatedly generate new multisig addresses for the same group of people.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4504#discussion_r485690507
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200909/51e49248/attachment-0001.html>