[bisq-network/bisq] Set username when saving the account not on every text change (#4505)

Christoph Atteneder notifications at github.com
Wed Sep 9 15:26:37 UTC 2020


There is no elegant solution to do this as we didn't have a input normalization for e-mail, phonenumbers in Revolut before and I don't know what is possible to enter as a username.
So the workaround is to set the user name only when the account is saved and not on every text change which cause that only the first character will be added as account id in the payload.

See https://github.com/bisq-network/bisq/pull/4481#pullrequestreview-485066342
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4505

-- Commit Summary --

  * Set username when saving the account not on every text change

-- File Changes --

    M desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java (4)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/RevolutForm.java (22)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4505.patch
https://github.com/bisq-network/bisq/pull/4505.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4505
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200909/a1558803/attachment.html>


More information about the bisq-github mailing list