[bisq-network/bisq] Remove side effect in setUserName method and add extra handling for the (#4506)

[chimp1984]

moment we save the account. Only at that moment we check if we need to
set the accountId with the value of the userName.
We do that in the domain layer to avoid more domain logic code in the UI
layer.

Fixes bug found at:
https://github.com/bisq-network/bisq/pull/4481#pullrequestreview-485066342

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4506

-- Commit Summary --

  * Remove side effect in setUserName method and add extra handling for the

-- File Changes --

    M core/src/main/java/bisq/core/payment/PaymentAccount.java (5)
    M core/src/main/java/bisq/core/payment/RevolutAccount.java (22)
    M core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java (8)
    M core/src/main/java/bisq/core/user/User.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4506.patch
https://github.com/bisq-network/bisq/pull/4506.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4506
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200909/1dccc4db/attachment-0001.html>