[bisq-network/bisq] [DRAFT] Create new ping API method (#4502)

Stan notifications at github.com
Wed Sep 9 20:12:43 UTC 2020


@chimp1984 
> RE:  The balance though might be a bit tricky. You can create an offer in Bisq UI with 0 BTC balance but need to fund it then in the create (or take) offer process. So in the UI it is not required to have balance as you also dont know in advance how much is required before the user defines the details of the offer (amount, sec. deposit).

The balance check is for a non-null value.  A 0 balance passes the test.  When create & take offer is implemented, it will have to check funds for the offer, but that's not in the scope of this PR. (Those API methods don't exist yet.)

>  ...  It can be added to your core API class and you simply request that.  I would not mix that with ping/pong as that has another meaning (testing network availibility or keep connections alive).

I agree `ping` is not be a proper name for the method/meaning.

We still need to discuss this issue... I'm not sure you know the requirement (now) is to provide a single method for determining if the server is ready for any & all operations -- that all the criteria in the checks are met, or the server is not ready to take requests.  There is no requirement (yet) for fine grained checks particular to a specific operation, excepting the existing checks in the `CoreWalletsService`.  That is out of the scope of getting a "simplest trading script" ready to show other devs and users.  I'm supposed to keep the demo'd API as simple as possible.  

So, `ping` should be renamed, not exposed to the user, and only be used by other api methods to check readiness for the more complex operations.   Would that be OK for you?




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4502#issuecomment-689795730
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200909/6716ef1c/attachment.html>


More information about the bisq-github mailing list