[bisq-network/bisq] <!-- - make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md) - make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues) - pick a descriptive title - provide some meaningful PR description below - create the PR - in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation. - After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required". --> (#4528)

Christoph Atteneder notifications at github.com
Tue Sep 15 07:27:26 UTC 2020 

Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr

Your PR description here.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4528

-- Commit Summary --

  * Bump version number for v1.3.8
  * Update translations for v1.3.8
  * Add dontShowAgain button in osxKeyLoggerWarning window
  * Rmove short cut info for removed key handlers
  * Refactor dependency structure to enable adding dispute managers
  * Add check if dispute is open
  * Enable onFiatPaymentReceived again (was for dev testing)
  * Ensure that p2p network and wallet are ready
  * Make var local
  * Set default services based on localhost check not on devMode check
  * Change min required confirmations from 0 to 1.
  * Add monero orange color code for tx confidence indicator
  * Show tx confidence indicator for XMR blocks. Show info icon
  * Adjust auto-conf css for badge
  * Add null check. Improve text
  * Do not overwrite useDevMode with useDevModeHeader
  * Change hex color code to lower case
  * Fix bug with all mobile notifications for disputes are sent at startup.
  * Add new Monero Explorer node77.monero.wiz.biz with onion
  * Fix compile error in core/src/main/java/bisq/core/user/Preferences.java
  * Remove offer from takers offerbook after take offer is completed.
  * Scan disputes for accounts where same user used diff. real names.
  * Remove unused var
  * Add alert icon to list entries
  * Remove unused method
  * Add JsonExclude to userName
  * Add check if xmrTxProof is used to avoid null pointer exception
  * Move revolutAccountsUpdateHandler code up to BisqSetup
  * Fix handling of username/accountId
  * Improve handling of nullable assetTxProof fields
  * Minor bug fixes for XMR tx proof feature
  * Bug fixes
  * Create new HttpClient for each request.
  * Remove DevTestXmrTxProofHttpClient
  * Resolve conflict in 6a061d2c5
  * Remove DevTestXmrTxProofHttpClient
  * Add note to SetXmrTxKeyWindow
  * Change from http port 80 clearnet to https 443
  * Resolve merge conflict in Merge conflict in desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java
  * Resolve merge conflict in Merge conflict in desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java
  * Add comment to empty method
  * Add check if trade have been dispute to protocol classes
  * Use a checkArgument to ensure that the methods are not called once a
  * Resolve merge conflict in Merge conflict in desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java
  * Ignore future results in case we had a terminal result already.
  * Rearrange fields and improve toString method
  * Improve text in UI in case of failure or error
  * Replace old Bisq Explorer URLs with new Mempool URLs for the 3 we have
  * Tweak strings of "BSQ Explorer" -> "Bisq Explorer" and "Bitcoin Explorer"
  * Improve handling of p2pNetworkAndWalletReady
  * Move remove code from shutDown to onP2pNetworkAndWalletReady
  * Use lots of regex to add http or https for XMR explorer API endpoint
  * Tweak string for "Service Addresses" to "Monero Explorer URLs"
  * Fix codacy complaining about missing space character
  * Rename Monero Explorer to friendlier hostname explorer.monero.wiz.biz
  * Remove side effect in setUserName method and add extra handling for the
  * Update data stores for v1.3.8
  * Add new Monero explorer xmrblocks.bisq.services with onion
  * Revert Tether USD for now due to various issues
  * Increase timeouts
  * Update data stores for v1.3.8 (second attempt)
  * Revert to SNAPSHOT version

-- File Changes --

    D assets/src/main/java/bisq/asset/coins/TetherUSDLiquid.java (12)
    D assets/src/main/java/bisq/asset/coins/TetherUSDOmni.java (12)
    D assets/src/main/java/bisq/asset/tokens/TetherUSDERC20.java (11)
    M assets/src/main/resources/META-INF/services/bisq.asset.Asset (3)
    M build.gradle (2)
    M common/src/main/java/bisq/common/app/Version.java (2)
    M core/src/main/java/bisq/core/app/BisqExecutable.java (3)
    M core/src/main/java/bisq/core/app/BisqSetup.java (14)
    M core/src/main/java/bisq/core/notifications/alerts/DisputeMsgEvents.java (53)
    M core/src/main/java/bisq/core/payment/PaymentAccount.java (5)
    M core/src/main/java/bisq/core/payment/PaymentAccountUtil.java (9)
    M core/src/main/java/bisq/core/payment/RevolutAccount.java (26)
    M core/src/main/java/bisq/core/payment/payload/BankAccountPayload.java (2)
    M core/src/main/java/bisq/core/payment/payload/CashDepositAccountPayload.java (2)
    M core/src/main/java/bisq/core/payment/payload/ChaseQuickPayAccountPayload.java (2)
    M core/src/main/java/bisq/core/payment/payload/ClearXchangeAccountPayload.java (2)
    M core/src/main/java/bisq/core/payment/payload/InteracETransferAccountPayload.java (2)
    M core/src/main/java/bisq/core/payment/payload/JapanBankAccountPayload.java (7)
    M core/src/main/java/bisq/core/payment/payload/MoneyGramAccountPayload.java (2)
    A core/src/main/java/bisq/core/payment/payload/PayloadWithHolderName.java (22)
    M core/src/main/java/bisq/core/payment/payload/PopmoneyAccountPayload.java (2)
    M core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java (90)
    M core/src/main/java/bisq/core/payment/payload/SepaAccountPayload.java (3)
    M core/src/main/java/bisq/core/payment/payload/SepaInstantAccountPayload.java (2)
    M core/src/main/java/bisq/core/payment/payload/SwishAccountPayload.java (2)
    M core/src/main/java/bisq/core/payment/payload/USPostalMoneyOrderAccountPayload.java (2)
    M core/src/main/java/bisq/core/payment/payload/WesternUnionAccountPayload.java (2)
    M core/src/main/java/bisq/core/provider/price/PriceProvider.java (26)
    A core/src/main/java/bisq/core/support/dispute/agent/MultipleHolderNameDetection.java (270)
    M core/src/main/java/bisq/core/support/messages/ChatMessage.java (8)
    M core/src/main/java/bisq/core/trade/TradeManager.java (44)
    M core/src/main/java/bisq/core/trade/TradeModule.java (4)
    M core/src/main/java/bisq/core/trade/protocol/BuyerAsMakerProtocol.java (5)
    M core/src/main/java/bisq/core/trade/protocol/BuyerAsTakerProtocol.java (4)
    M core/src/main/java/bisq/core/trade/protocol/SellerAsMakerProtocol.java (5)
    M core/src/main/java/bisq/core/trade/protocol/SellerAsTakerProtocol.java (4)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java (6)
    M core/src/main/java/bisq/core/trade/protocol/tasks/seller/SellerProcessCounterCurrencyTransferStartedMessage.java (6)
    M core/src/main/java/bisq/core/trade/txproof/AssetTxProofResult.java (31)
    M core/src/main/java/bisq/core/trade/txproof/AssetTxProofService.java (12)
    D core/src/main/java/bisq/core/trade/txproof/xmr/DevTestXmrTxProofHttpClient.java (206)
    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofHttpClient.java (7)
    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofParser.java (2)
    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofRequest.java (31)
    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofRequestsPerTrade.java (149)
    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofService.java (264)
    M core/src/main/java/bisq/core/user/AutoConfirmSettings.java (25)
    M core/src/main/java/bisq/core/user/Preferences.java (44)
    M core/src/main/java/bisq/core/user/PreferencesPayload.java (2)
    M core/src/main/java/bisq/core/user/User.java (14)
    M core/src/main/resources/i18n/displayStrings.properties (37)
    M core/src/main/resources/i18n/displayStrings_de.properties (70)
    M core/src/main/resources/i18n/displayStrings_es.properties (72)
    M core/src/main/resources/i18n/displayStrings_fa.properties (70)
    M core/src/main/resources/i18n/displayStrings_fr.properties (70)
    M core/src/main/resources/i18n/displayStrings_ja.properties (70)
    M core/src/main/resources/i18n/displayStrings_pt-br.properties (70)
    M core/src/main/resources/i18n/displayStrings_pt.properties (70)
    M core/src/main/resources/i18n/displayStrings_ru.properties (70)
    M core/src/main/resources/i18n/displayStrings_th.properties (70)
    M core/src/main/resources/i18n/displayStrings_vi.properties (70)
    M core/src/main/resources/i18n/displayStrings_zh-hans.properties (70)
    M core/src/main/resources/i18n/displayStrings_zh-hant.properties (70)
    M desktop/package/linux/Dockerfile (2)
    M desktop/package/linux/package.sh (2)
    M desktop/package/linux/release.sh (2)
    M desktop/package/macosx/Info.plist (4)
    M desktop/package/macosx/create_app.sh (2)
    M desktop/package/macosx/finalize.sh (2)
    M desktop/package/macosx/insert_snapshot_version.sh (2)
    M desktop/package/macosx/replace_version_number.sh (4)
    M desktop/package/windows/package.bat (2)
    M desktop/package/windows/release.bat (2)
    M desktop/src/main/java/bisq/desktop/bisq.css (17)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/RevolutForm.java (22)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (10)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBook.java (24)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java (17)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/SetXmrTxKeyWindow.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/TradeStepView.java (30)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (22)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep3View.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep4View.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep2View.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java (159)
    M desktop/src/main/java/bisq/desktop/main/settings/about/AboutView.java (10)
    M desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java (44)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/DisputeView.java (51)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/agent/DisputeAgentView.java (191)
    M desktop/src/main/java/bisq/desktop/theme-dark.css (3)
    M desktop/src/main/java/bisq/desktop/theme-light.css (3)
    M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (122)
    M desktop/src/test/java/bisq/desktop/util/GUIUtilTest.java (214)
    M p2p/src/main/java/bisq/network/http/HttpClientImpl.java (4)
    M p2p/src/main/java/bisq/network/p2p/network/Connection.java (2)
    M p2p/src/main/java/bisq/network/p2p/network/TorNetworkNode.java (2)
    M p2p/src/main/java/bisq/network/p2p/peers/getdata/GetDataRequestHandler.java (2)
    M p2p/src/main/java/bisq/network/p2p/peers/peerexchange/GetPeersRequestHandler.java (2)
    M p2p/src/main/java/bisq/network/p2p/peers/peerexchange/PeerExchangeHandler.java (2)
    M p2p/src/main/resources/AccountAgeWitnessStore_BTC_MAINNET (4)
    M p2p/src/main/resources/DaoStateStore_BTC_MAINNET (4)
    M p2p/src/main/resources/SignedWitnessStore_BTC_MAINNET (4)
    M p2p/src/main/resources/TradeStatistics2Store_BTC_MAINNET (4)
    M relay/src/main/resources/version.txt (2)
    M seednode/src/main/java/bisq/seednode/SeedNodeMain.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4528.patch
https://github.com/bisq-network/bisq/pull/4528.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4528
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200915/46d22eff/attachment-0001.html>

More information about the bisq-github mailing list