[bisq-network/bisq] Add core support for registration of regtest dispute agents via API (#4524)

[sqrrm]

@sqrrm requested changes on this pull request.



> +                ECKey ecKey = mediatorManager.getRegistrationKey(registrationKey);
+                String signature = mediatorManager.signStorageSignaturePubKey(Objects.requireNonNull(ecKey));

Both of these work the same at the moment, but it would be correct to use the specific manager depending on case. Better make a disputeAgentManager and set to whichever type is being registered, or just move the specific registration code to their switch cases.

> +                                  List<String> languageCodes,
+                                  ECKey ecKey,
+                                  String signature) {
+        Mediator mediator = new Mediator(
+                nodeAddress,
+                keyRing.getPubKeyRing(),
+                languageCodes,
+                new Date().getTime(),
+                ecKey.getPubKey(),
+                signature,
+                null,
+                null,
+                null
+        );
+        mediatorManager.addDisputeAgent(mediator, () -> {
+        }, errorMessage -> {

This is some ugly indentation, seems it's what we have specified as our standard though, and codacy agrees. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4524#pullrequestreview-489597573
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200916/bbfa1bf0/attachment.html>