[bisq-network/bisq] Upgrade JavaFX to v14 (#4242)

[coinzdude]

I'm building with a recent bisq master plus your commits.

OpenJDK 11 is working for me as well, the app appears to be fully functional.

On windows, with java 14.0.2+12-46
Everything builds, and at runtime, I get the below, and it hangs at end of connecting to 13 peers

```
Sep-11 17:48:13.319 [PeerGroup Thread] INFO  o.b.c.PeerGroup: Attempting connection to [lva54pnbq2nsmjyr.onion]:8333     (0 connected, 9 pending, 9 max) 
Sep-11 17:48:13.416 [JavaFX Application Thread] INFO  b.c.a.BisqSetup: Wallet password required 
Sep-11 17:48:13.417 [JavaFX Application Thread] INFO  b.c.a.BisqSetup: onRequestWalletPassword 
Sep-11 17:48:13.417 [JavaFX Application Thread] INFO  b.c.a.BisqSetup: onRequestWalletPassword 
Sep-11 17:48:13.657 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: Uncaught Exception from thread JavaFX Application Thread 
Sep-11 17:48:13.658 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: throwableMessage= null 
Sep-11 17:48:13.658 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: throwableClass= class java.lang.NullPointerException 
Sep-11 17:48:13.660 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: Stack trace:
java.lang.NullPointerException
	at bisq.desktop.components.JFXTextFieldSkinBisqStyle.updateTextPos(JFXTextFieldSkinBisqStyle.java:95)
	at bisq.desktop.components.JFXTextFieldSkinBisqStyle.layoutChildren(JFXTextFieldSkinBisqStyle.java:79)
	at javafx.scene.control.Control.layoutChildren(Control.java:601)
	at javafx.scene.Parent.layout(Parent.java:1207)
	at javafx.scene.Parent.layout(Parent.java:1214)
	at javafx.scene.Scene.doLayoutPass(Scene.java:576)
	at javafx.scene.Scene.preferredSize(Scene.java:1784)
	at javafx.scene.Scene$2.preferredSize(Scene.java:393)
	at com.sun.javafx.scene.SceneHelper.preferredSize(SceneHelper.java:66)
	at javafx.stage.Window$12.invalidated(Window.java:1086)
	at javafx.beans.property.BooleanPropertyBase.markInvalid(BooleanPropertyBase.java:110)
	at javafx.beans.property.BooleanPropertyBase.set(BooleanPropertyBase.java:145)
	at javafx.stage.Window.setShowing(Window.java:1174)
	at javafx.stage.Window.show(Window.java:1189)
	at javafx.stage.Stage.show(Stage.java:273)
	at bisq.desktop.main.overlays.Overlay.display(Overlay.java:538)
	at bisq.desktop.main.overlays.windows.WalletPasswordWindow.show(WalletPasswordWindow.java:149)
	at bisq.desktop.main.MainViewModel.lambda$setupHandlers$14(MainViewModel.java:332)
	at bisq.core.app.BisqSetup.lambda$initWallet$9(BisqSetup.java:584)
	at bisq.core.app.WalletAppSetup.lambda$init$2(WalletAppSetup.java:167)
	at bisq.common.reactfx.FxTimer.lambda$restart$0(FxTimer.java:93)
	at com.sun.scenario.animation.shared.TimelineClipCore.visitKeyFrame(TimelineClipCore.java:239)
	at com.sun.scenario.animation.shared.TimelineClipCore.playTo(TimelineClipCore.java:180)
	at javafx.animation.Timeline.doPlayTo(Timeline.java:175)
	at javafx.animation.AnimationAccessorImpl.playTo(AnimationAccessorImpl.java:39)
	at com.sun.scenario.animation.shared.SingleLoopClipEnvelope.timePulse(SingleLoopClipEnvelope.java:97)
	at javafx.animation.Animation.doTimePulse(Animation.java:1101)
	at javafx.animation.Animation$1.lambda$timePulse$0(Animation.java:186)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at javafx.animation.Animation$1.timePulse(Animation.java:185)
	at com.sun.scenario.animation.AbstractMasterTimer.timePulseImpl(AbstractMasterTimer.java:344)
	at com.sun.scenario.animation.AbstractMasterTimer$MainLoop.run(AbstractMasterTimer.java:267)
	at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:559)
	at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:543)
	at com.sun.javafx.tk.quantum.QuantumToolkit.pulseFromQueue(QuantumToolkit.java:536)
	at com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$11(QuantumToolkit.java:342)
	at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
	at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
	at com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
	at java.base/java.lang.Thread.run(Thread.java:832)
 
Sep-11 17:48:17.376 [BlockingClient network thread for fz6nsij6jiyuwlsc.onion/<unresolved>:8333] INFO  o.b.core.Peer: Announcing to fz6nsij6jiyuwlsc.onion/<unresolved>:8333 as: /bitcoinj:0.14.7.bisq.1-SNAPSHOT/Bisq:1.3.7/ 
Sep-11 17:48:17.679 [NetworkNode:SendMessage-to-wizseed3d376esppbmbjxk2fhk2jg5fpucddrzj2kxtbxbx4vrnwclad.onion:8000] INFO  b.n.p.n.NetworkNode: Socket creation to peersNodeAddress wizseed3d376esppbmbjxk2fhk2jg5fpucddrzj2kxtbxbx4vrnwclad.onion:8000 took 4601 ms 

```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4242#issuecomment-693446062
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200916/3353f884/attachment.html>