[bisq-network/bisq] Add cancel trade feature (#4514)

[chimp1984]

@chimp1984 commented on this pull request.



> +            Transaction depositTx = checkNotNull(trade.getDepositTx());
+            String tradeId = trade.getId();
+            TradingPeer tradingPeer = processModel.getTradingPeer();
+            BtcWalletService walletService = processModel.getBtcWalletService();
+            Offer offer = checkNotNull(trade.getOffer(), "offer must not be null");
+            Coin tradeAmount = checkNotNull(trade.getTradeAmount(), "tradeAmount must not be null");
+            Contract contract = checkNotNull(trade.getContract(), "contract must not be null");
+
+            checkNotNull(trade.getTradeAmount(), "trade.getTradeAmount() must not be null");
+
+            byte[] mySignature = checkNotNull(processModel.getCanceledTradePayoutTxSignature(),
+                    "processModel.getTxSignatureFromCanceledTrade must not be null");
+            byte[] peersSignature = checkNotNull(tradingPeer.getCanceledTradePayoutTxSignature(),
+                    "tradingPeer.getTxSignatureFromCanceledTrade must not be null");
+
+            boolean isMyRoleBuyer = contract.isMyRoleBuyer(processModel.getPubKeyRing());

Which check do you mean? isMyRoleBuyer is used to set buyer/seller sig correctly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4514#discussion_r489839687
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200916/123d18fc/attachment.html>