[bisq-network/bisq] Reduce initial request size (#4233)

chimp1984 notifications at github.com
Thu Sep 17 01:17:48 UTC 2020


@chimp1984 requested changes on this pull request.

NACK

Basic concept is ok but many impl. elements are not acceptable IMO. Specially the hack to encode the version into the payload of the hashes instead of adding a new protobug field to the request msg.

I suggest that we use #4519 which is based on this PR one but has a lot of changes. It is still WIP and not much tested, should be ready for review in a few days...




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4233#pullrequestreview-490179040
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200916/f1a21573/attachment.html>


More information about the bisq-github mailing list