[bisq-network/bisq] [WIP] Add cancel trade feature (#4514)

sqrrm notifications at github.com
Thu Sep 17 07:06:16 UTC 2020


@sqrrm commented on this pull request.



> +            Transaction depositTx = checkNotNull(trade.getDepositTx());
+            String tradeId = trade.getId();
+            TradingPeer tradingPeer = processModel.getTradingPeer();
+            BtcWalletService walletService = processModel.getBtcWalletService();
+            Offer offer = checkNotNull(trade.getOffer(), "offer must not be null");
+            Coin tradeAmount = checkNotNull(trade.getTradeAmount(), "tradeAmount must not be null");
+            Contract contract = checkNotNull(trade.getContract(), "contract must not be null");
+
+            checkNotNull(trade.getTradeAmount(), "trade.getTradeAmount() must not be null");
+
+            byte[] mySignature = checkNotNull(processModel.getCanceledTradePayoutTxSignature(),
+                    "processModel.getTxSignatureFromCanceledTrade must not be null");
+            byte[] peersSignature = checkNotNull(tradingPeer.getCanceledTradePayoutTxSignature(),
+                    "tradingPeer.getTxSignatureFromCanceledTrade must not be null");
+
+            boolean isMyRoleBuyer = contract.isMyRoleBuyer(processModel.getPubKeyRing());

Yeah, why is there a check for what role is active when we know it's the seller?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4514#discussion_r490016926
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200917/cfe973b6/attachment-0001.html>


More information about the bisq-github mailing list