[bisq-network/bisq] [WIP] Add cancel trade feature (#4514)

sqrrm notifications at github.com
Thu Sep 17 07:07:38 UTC 2020


@sqrrm commented on this pull request.



> @@ -90,7 +90,13 @@ protected void run() {
 
             signedWitness = signedWitnessOptional.get();
 
-            // Message sending is handled in base class.
+            // The signer broadcasts as well the signedWitness. In case the receiver will not get the message we have
+            // better resilience that the data is in the network. We set reBroadcast to true but do not expect that the
+            // signedWitness exists already as we just created it.
+            // TODO check with @sqrrm
+            processModel.getP2PService().addPersistableNetworkPayload(signedWitness, true);

Yeah, comment was made on old commit, not on final version. I comment as I go through the code...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4514#discussion_r490017555
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200917/3659f23b/attachment.html>


More information about the bisq-github mailing list