[bisq-network/bisq] Upgrade JavaFX to v14 (#4242)

Chris Beams notifications at github.com
Thu Sep 17 08:15:27 UTC 2020


@cbeams commented on this pull request.



> @@ -1,9 +1,9 @@
 # How to upgrade the Gradle version
 
 Visit the [Gradle website](https://gradle.org/releases/) and decide the:
-*  desired version
-*  desired distribution type
-*  what is the sha256 for the version and type chosen
+*   desired version
+*   desired distribution type
+*   what is the sha256 for the version and type chosen

Nit: this double-spacing after the bullet point is pretty unconventional. Usual syntax throughout most of the codebase is:
```
 - first bullet point
 - second bullet point
```

Note that more than 75% use dashes vs asterisks as well.

Run `find . -name '*.md' | xargs grep '^ \?[-*] '` for details.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4242#pullrequestreview-490349638
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200917/f5ee9310/attachment.html>


More information about the bisq-github mailing list