[bisq-network/bisq] Trasaction broadcast bug (#4538)

[hodlwave]

@jmacxx, here's my (blinded) logfile with more context around the `TxBroadcastTimeoutException`. Nothing particularly jumps out at me (maybe `Waiting for 4 peers required for broadcast, we have 3`?).
```
[JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: BuyerAsTakerCreatesDepositTxInputs 
[JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: TakerSendInputsForDepositTxRequest 
[JavaFX Application Thread] INFO  b.c.t.p.t.t.TakerSendInputsForDepositTxRequest: Send InputsForDepositTxRequest with offerId ... and uid ... to peer ...
[JavaFX Application Thread] INFO  b.c.o.a.OfferAvailabilityProtocol: AckMessage for OfferAvailabilityResponse arrived at makersNodeAddress .... offerId=...
[JavaFX Application Thread] INFO  b.c.t.p.BuyerAsTakerProtocol: Received InputsForDepositTxResponse from ... with tradeId ... and uid ...
[JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: TakerProcessesInputsForDepositTxResponse 
[JavaFX Application Thread] INFO  b.c.t.p.t.t.TakerProcessesInputsForDepositTxResponse: lockTime=..., delay=-2880
[JavaFX Application Thread] INFO  b.c.trade.Trade: Set new state at BuyerAsTakerTrade (id=...): TAKER_RECEIVED_PUBLISH_DEPOSIT_TX_REQUEST 
[JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: ApplyFilter 
[JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: TakerVerifyMakerAccount 
[JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: VerifyPeersAccountAgeWitness 
[JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: TakerVerifyMakerFeePayment 
[JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: TakerVerifyAndSignContract 
[JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: TakerPublishFeeTx 
[JavaFX Application Thread] INFO  o.b.w.Wallet: commitTx of ...
[JavaFX Application Thread] INFO  o.b.w.Wallet:   marked ...:1 as spent by ... 
[JavaFX Application Thread] INFO  o.b.w.Wallet:   ... prevtx <-unspent ->spent 
[JavaFX Application Thread] INFO  o.b.w.Wallet: ->pending: ...
[JavaFX Application Thread] INFO  o.b.w.Wallet: Estimated balance is now: ... BTC 
[JavaFX Application Thread] INFO  o.b.w.WalletFiles: Saving wallet; last seen block is height ..., date ..., hash ...
[JavaFX Application Thread] INFO  o.b.w.WalletFiles: Save completed in 5.595 ms 
[JavaFX Application Thread] INFO  o.b.c.TransactionBroadcast: Waiting for 4 peers required for broadcast, we have 3 ... 
[JavaFX Application Thread] INFO  b.c.t.p.TradeProtocol: Received AckMessage for InputsForDepositTxRequest from ... with tradeId ... and uid ...
[PeerGroup Thread] WARN  o.b.n.BlockingClient: Attempted to write to a closed socket. 
[PeerGroup Thread] WARN  o.b.n.BlockingClient: Attempted to write to a closed socket. 
[JavaFX Application Thread] WARN  b.c.b.w.TxBroadcaster: Broadcast of tx ... not completed after 5 sec. 
[JavaFX Application Thread] WARN  b.c.b.w.TxBroadcaster: TxBroadcaster.onTimeout called: TxBroadcastTimeoutException{
     localTx=  ...
  updated: ...
     in   PUSHDATA(72)[...] PUSHDATA(33)[...] ... BTC (...)
          outpoint:...:1 hash160:...
     out  HASH160 PUSHDATA(20)[...] EQUAL ... BTC (...) ScriptPubKey: ... Address:...
     out  DUP HASH160 PUSHDATA(20)[...] EQUALVERIFY CHECKSIG ... BTC (...) ScriptPubKey: ... Address:...
     fee  ... BTC for 224 bytes (... Satoshi/Byte)
     prps USER_PAYMENT
,
     delay=5
} TxBroadcastException{
     txId='null'
} bisq.core.btc.exceptions.TxBroadcastTimeoutException: The transaction was not broadcasted in 5 seconds. txId=... 
[JavaFX Application Thread] INFO  b.c.trade.Trade: Set new state at BuyerAsTakerTrade (id=...): TAKER_PUBLISHED_TAKER_FEE_TX 
[JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: BuyerAsTakerSignsDepositTx 
[JavaFX Application Thread] INFO  b.c.b.w.WalletService: 
makersDepositTx:
  ...
     in   <no scriptSig>
          outpoint:...
     in   <no scriptSig>
          outpoint:...:1
     out  HASH160 PUSHDATA(20)[...] EQUAL ... BTC (...) ... Address:...
     out  RETURN PUSHDATA(32)[...] 0.00 BTC (0) ScriptPubKey: ... Address:[exception: Cannot cast this script to a pay-to-address type]
     prps UNKNOWN
 
[JavaFX Application Thread] INFO  b.c.b.w.WalletService: 
takerSignsDepositTx:
  ...
     in   PUSHDATA(71)[...] PUSHDATA(33)[...] ... BTC (...)
          outpoint:...:1 hash160:hash160:
     in   <no scriptSig> ... BTC (...)
          outpoint:...:1 hash160:...
     out  HASH160 PUSHDATA(20)[...] EQUAL ... BTC (...) ScriptPubKey: ... Address:...
     out  RETURN PUSHDATA(32)[...] 0.00 BTC (0) ScriptPubKey: ... Address:[exception: Cannot cast this script to a pay-to-address type]
     fee  ... BTC for 273 bytes (... Satoshi/Byte)
     prps UNKNOWN
 
[JavaFX Application Thread] INFO  b.c.t.p.t.b.BuyerAsTakerSendsDepositTxMessage: Send DepositTxMessage to peer .... tradeId=..., uid=...
[JavaFX Application Thread] INFO  b.c.t.p.t.b.BuyerAsTakerSendsDepositTxMessage: DepositTxMessage arrived at peer .... tradeId=..., uid=... 
[JavaFX Application Thread] INFO  b.c.t.p.TradeProtocol: Send AckMessage for InputsForDepositTxResponse to peer .... tradeId=..., sourceUid= 
[JavaFX Application Thread] INFO  b.c.t.p.TradeProtocol: AckMessage for InputsForDepositTxResponse arrived at peer .... tradeId=..., sourceUid= 
[JavaFX Application Thread] INFO  b.c.t.p.BuyerAsTakerProtocol: Received DelayedPayoutTxSignatureRequest from ... with tradeId ... and uid ...
[JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: BuyerVerifiesPreparedDelayedPayoutTx 
```

@chimp1984 
Bisq is not connected to a local Bitcoin node. My environment could well be the issue as I'm running v.1.3.7 in an ad hoc docker container (https://github.com/leshik/bisq-docker), although it seems kind of odd that only one type of network communication would fail since all data is going over Tor. I will try to reproduce on regtest if I get some time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4538#issuecomment-695157109
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200918/e57970e6/attachment.html>