[bisq-network/bisq] Refactor API & add registerdisputeagent method to CLI (#4539)

[chimp1984]

@chimp1984 commented on this pull request.



> -        paymentAccount.init();
-        paymentAccount.setAccountName(accountName);
-        ((PerfectMoneyAccount) paymentAccount).setAccountNr(accountNumber);
-        paymentAccount.setSingleTradeCurrency(new FiatCurrency(fiatCurrencyCode.toUpperCase()));
-        user.addPaymentAccount(paymentAccount);
+    void createPaymentAccount(String paymentMethodId,
+                              String accountName,
+                              String accountNumber,
+                              String currencyCode) {
+
+        PaymentAccount paymentAccount = getNewPaymentAccount(paymentMethodId,
+                accountName,
+                accountNumber,
+                currencyCode);
+
+        // TODO not sure if there is more to do at account creation.

Yes there is lots of extra stuff, mainly the many different payment methods with their custom requirements. Input validation, currency selection, country selection, etc...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4539#pullrequestreview-492894300
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200921/2b6f9a18/attachment-0001.html>