[bisq-network/bisq] Reduce apitest harness' dependency on string matching (#4540)
chimp1984
notifications at github.com
Mon Sep 21 19:08:51 UTC 2020
@chimp1984 approved this pull request.
utACK
> @@ -42,10 +44,14 @@
@TestMethodOrder(OrderAnnotation.class)
public class RegisterDisputeAgentsTest extends MethodTest {
+ private static final String ARBITRATOR = "arbitrator";
I guess those constants would be good to have in the domain classes and maybe enums are even better.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4540#pullrequestreview-492902338
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200921/64674737/attachment.html>
More information about the bisq-github
mailing list