[bisq-network/bisq] Upgrade JavaFX to v14 (#4242)
cd2357
notifications at github.com
Tue Sep 22 17:44:20 UTC 2020
> The next time you force push or push with new commits to this PR the Codacy complaints should be gone.
Thanks @ripcurlx
Talking about Codacy, I saw a lot of frustration around this tool recently, with people writing less-safe code (https://github.com/bisq-network/bisq/pull/4504#issuecomment-695133780), or writing less-readable code
(https://github.com/bisq-network/bisq/pull/4504#issuecomment-695156510), just to get the bot's approval and have their PRs mergeable.
Good news is that the problem is not with Codacy, but with how Bisq integrates it. I think now it's configured as a "mandatory" check that must pass before PRs can be merged into a protected branch. But it can be made "non-mandatory", so even if a check fails with a false positive, which happens often, if the reviewers ACK that PR, it could still be merged. See https://github.com/bisq-network/bisq/pull/4504#issuecomment-695207917 for details. Of course, if the checks fail and the reviewers agree with the bot, the PR author still has to fix what the bot found.
Might be worth considering, would spare devs and reviewers a lot of frustration :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4242#issuecomment-696875164
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200922/83d52269/attachment.html>
More information about the bisq-github
mailing list