[bisq-network/bisq] Add 'createoffer' api method (#4554)

[Stan]

This updates the existing gRPC `createoffer` method to return the new Offer instead of a boolean.  Although `createoffer` still places the offer, it might be changed to give the user a chance to examine a newly created (and cached) offer before it is placed in a separate `confirmoffer offer-id`  or  `placeoffer offer-id` method.  

An api test case was added and the CLI's `createoffer` method was stubbed out -- to be implemented in another PR.

Several unrelated, minor changes were pushed before the most relevant ones.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4554

-- Commit Summary --

  * Replace hardcoded version with Version.java value
  * Remove comment
  * Move test dispute agent type constants to core
  * Fix indentation
  * Add simple create payment acct test
  * Remove final modifiers
  * Don't use static boilerplate helpers if not necessary
  * Remove comment
  * Add get default payment acct helper
  * Stub out createoffer method in CLI
  * Change API's createoffer return value from bool to Offer
  * Add API CreateOfferTest case

-- File Changes --

    M apitest/scripts/mainnet-test.sh (6)
    A apitest/scripts/version-parser.bash (5)
    A apitest/src/test/java/bisq/apitest/method/CreateOfferTest.java (112)
    A apitest/src/test/java/bisq/apitest/method/CreatePaymentAccountTest.java (98)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (58)
    M apitest/src/test/java/bisq/apitest/method/RegisterDisputeAgentsTest.java (15)
    M cli/src/main/java/bisq/cli/CliMain.java (7)
    M core/src/main/java/bisq/core/api/CoreApi.java (48)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (85)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (2)
    M core/src/main/java/bisq/core/support/dispute/agent/DisputeAgent.java (6)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (64)
    M proto/src/main/proto/grpc.proto (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4554.patch
https://github.com/bisq-network/bisq/pull/4554.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4554
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200922/3988628d/attachment.html>