[bisq-network/bisq] Use existing timer in unlockwallet(pwd, timeout) (#4558)

Stan notifications at github.com
Wed Sep 23 15:23:21 UTC 2020


This is one of the changes @chimp1984 requested in https://github.com/chimp1984/bisq/commit/961703ecea62df62946ab001ec28205662688ccd.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4558

-- Commit Summary --

  * Replace hardcoded version with Version.java value
  * Remove comment
  * Move test dispute agent type constants to core
  * Fix indentation
  * Add simple create payment acct test
  * Remove final modifiers
  * Don't use static boilerplate helpers if not necessary
  * Remove comment
  * Add get default payment acct helper
  * Stub out createoffer method in CLI
  * Change API's createoffer return value from bool to Offer
  * Add API CreateOfferTest case
  * Fix imports
  * Fix unnecessary use of fully qualified name
  * Use existing timer in unlockwallet(pwd, timeout)

-- File Changes --

    M apitest/scripts/mainnet-test.sh (6)
    A apitest/scripts/version-parser.bash (5)
    A apitest/src/test/java/bisq/apitest/method/CreateOfferTest.java (112)
    A apitest/src/test/java/bisq/apitest/method/CreatePaymentAccountTest.java (98)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (56)
    M apitest/src/test/java/bisq/apitest/method/RegisterDisputeAgentsTest.java (15)
    M cli/src/main/java/bisq/cli/CliMain.java (7)
    M core/src/main/java/bisq/core/api/CoreApi.java (48)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (85)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (2)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (32)
    M core/src/main/java/bisq/core/support/dispute/agent/DisputeAgent.java (6)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (64)
    M proto/src/main/proto/grpc.proto (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4558.patch
https://github.com/bisq-network/bisq/pull/4558.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4558
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200923/a342fa3a/attachment-0001.html>


More information about the bisq-github mailing list