[bisq-network/bisq] Upgrade JavaFX to v15 (#4242)

[cd2357]

Interesting.

Building a `dmg` in the same environment as you, then runnin Bisq -> I get the same error as you, when I try to open Account > Wallet Seed.

However: running the same code in Intellij, Account > Wallet Seed works fine.

Same branch, same environment. One had the error, one didn't. I guess Intellij does some magic in how it handles and packages javafx? Not sure. But this means the best way to test this PR is by checking out and building in a "non-workspace" temp folder, to eliminate any Intellij influences. (Maybe a similar effect explains why @ghubstan and you got different results when testing his PR #4443?)

@ghubstan I cherrypicked your jfoenix PR and applied it here -> now I don't get the error anymore. Works both when running the branch in Intellij + when building the `dmg` in a new "non-workspace" folder.

 Seems that #4443, even though it was reverted, wasn't in vain :) 

@ripcurlx Can you confirm if this fixes it for you too?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4242#issuecomment-697798550
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200923/dd0c1eb3/attachment-0001.html>