[bisq-network/bisq] Use existing timer in unlockwallet(pwd, timeout) (#4558)

[cd2357]

@cd2357 commented on this pull request.



> @@ -0,0 +1,5 @@
+#!/bin/bash
+
+# Bats helper script for parsing current version from Version.java.
+
+export CURRENT_VERSION=$(grep "String VERSION =" common/src/main/java/bisq/common/app/Version.java | sed 's/[^0-9.]*//g')

Nit: wouldn't it be better to script this in gradle instead of bash?

It would be platform independent and it could be tested by more devs (not restricted to those using mac or linux).

It would also make integration with the current codebase easier, like accessing `Version.CURRENT_VERSION` natively here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4558#pullrequestreview-495337652
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200924/b244dc47/attachment.html>