[bisq-network/bisq] Use existing timer in unlockwallet(pwd, timeout) (#4558)

Stan notifications at github.com
Thu Sep 24 11:24:35 UTC 2020


@ghubstan commented on this pull request.



> @@ -0,0 +1,5 @@
+#!/bin/bash
+
+# Bats helper script for parsing current version from Version.java.
+
+export CURRENT_VERSION=$(grep "String VERSION =" common/src/main/java/bisq/common/app/Version.java | sed 's/[^0-9.]*//g')

This script is loaded by a couple of api test cases in the bash based [bats](https://github.com/bats-core/bats-core) test script (`mainnet-test.sh`), which I'm pretty sure does not integrate with gradle or java.   This is an ugly solution, but I don't think running a gradle or java script could be any prettier.

Also, `apitest`,  and the API daemon & cli were not intended to run on Windows, at least in the short & medium term.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4558#discussion_r494235732
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200924/cf67adbc/attachment.html>


More information about the bisq-github mailing list