[bisq-network/bisq] Monero auto-confirm fails with AMOUNT_NOT_MATCHING or NO_MATCH_FOUND in certain cases (#4557)

[James Cox]

Thanks for the logs.  The amount check between bisq and the explorer API returned a difference after the 8th decimal place and AMOUNT_NOT_MATCHING was the result.  The difference was as follows:

    xx.xxxxxxxx7000 XMR expected by bisq
    xx.xxxxxxxx0000 XMR provided by explorer API

Looks like this should be fixed by truncating the last 4 digits of the amounts before comparing.  Especially since Bisq displays the XMR amount to be sent using 8 decimal places.

I should have anticipated this during testing.  Comparing numbers that have been achieved by converting one currency to another should always have a tolerance taken into account, and checking XMR amounts down to the 8th decimal should be adequate, even though Monero has 12.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4557#issuecomment-698335625
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200924/69f66f51/attachment.html>