[bisq-network/bisq] Monero auto-confirm fails with AMOUNT_NOT_MATCHING or NO_MATCH_FOUND in certain cases (#4557)

[James Cox]

Found the bug, XMR autoconfirm task is getting the amount from the offer; it should use the trade which can be different due to the taker's price having the chance to be slightly different.

https://github.com/bisq-network/bisq/blob/9ca3c8bded70f3d6270bcf4c134e5257f30bb981/core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofModel.java#L64

Should be:    `Volume volume = trade.getTradeVolume();`

This can be verified by doing an autoconfirm trade, forcing the taker's price to be different (L194 of TakeOfferDataModel).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4557#issuecomment-698435395
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200924/b25b4345/attachment.html>