[bisq-network/bisq] XMR autoconf should get amount from trade not offer (#4560)

chimp1984 notifications at github.com
Fri Sep 25 14:47:02 UTC 2020


@chimp1984 approved this pull request.

utACK

Could you reproduce the issue that it was really caused by that?

> @@ -60,8 +60,7 @@
         this.serviceAddress = serviceAddress;
         this.autoConfirmSettings = autoConfirmSettings;
 
-        Coin tradeAmount = trade.getTradeAmount();
-        Volume volume = checkNotNull(trade.getOffer()).getVolumeByAmount(tradeAmount);
+        Volume volume = trade.getTradeVolume();

Good catch. I think the trade price is the reason for the issue. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4560#pullrequestreview-496490307
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200925/643a7ac8/attachment.html>


More information about the bisq-github mailing list