[bisq-network/bisq] Revert "Deactive confirm buttons once mediation started" (#4562)

wiz notifications at github.com
Fri Sep 25 14:58:51 UTC 2020


Reverts bisq-network/bisq#4493

This change should have been discussed more before merging. Obviously disabling a UI button does not prevent a malicious person from abusing the trade protocol, and it only serves to degrade the UX of Bisq for honest traders who open a support ticket.

In the past week, about 50% of my mediation cases have traders who are complaining they can no longer resolve trades on their own because the mediation case is ongoing. As a mediator, it is my goal to mediate the trade so that the traders can complete the trade on their own, but now traders can no longer do so :sweat:
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4562

-- Commit Summary --

  * Revert "Deactive confirm buttons once mediation started"

-- File Changes --

    M core/src/main/java/bisq/core/trade/protocol/BuyerAsMakerProtocol.java (5)
    M core/src/main/java/bisq/core/trade/protocol/BuyerAsTakerProtocol.java (4)
    M core/src/main/java/bisq/core/trade/protocol/SellerAsMakerProtocol.java (5)
    M core/src/main/java/bisq/core/trade/protocol/SellerAsTakerProtocol.java (4)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/TradeStepView.java (17)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (8)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java (6)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4562.patch
https://github.com/bisq-network/bisq/pull/4562.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4562
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200925/5b3d14da/attachment-0001.html>


More information about the bisq-github mailing list