[bisq-network/bisq] Use existing timer in unlockwallet(pwd, timeout) (#4558)

[chimp1984]

@chimp1984 commented on this pull request.



> @@ -43,6 +43,12 @@
 public abstract class DisputeAgent implements ProtectedStoragePayload, ExpirablePayload {
     public static final long TTL = TimeUnit.DAYS.toMillis(10);
 
+    public enum DisputeAgentType {
+        ARBITRATOR,
+        MEDIATOR,
+        REFUNDAGENT

We use underscore if it would be a camelCase'ed word: -> REFUND_AGENT

> @@ -86,21 +90,53 @@ public void getOffers(GetOffersRequest req,
     @Override
     public void createOffer(CreateOfferRequest req,
                             StreamObserver<CreateOfferReply> responseObserver) {
-        TransactionResultHandler resultHandler = transaction -> {
-            CreateOfferReply reply = CreateOfferReply.newBuilder().setResult(true).build();
+        CountDownLatch latch = new CountDownLatch(1);
+        try {
+            TransactionResultHandler resultHandler = transaction -> {
+                latch.countDown();

Why use a CountDownLatch here instead continuing the code in the result handler? If there is n o strong reason for that can we stick to the style like it used elsewhere in the app?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4558#pullrequestreview-496748017
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200925/c5fe0f79/attachment-0001.html>