[bisq-network/bisq] Use existing timer in unlockwallet(pwd, timeout) (#4558)

Stan notifications at github.com
Fri Sep 25 19:49:35 UTC 2020


@ghubstan commented on this pull request.



> @@ -86,21 +90,53 @@ public void getOffers(GetOffersRequest req,
     @Override
     public void createOffer(CreateOfferRequest req,
                             StreamObserver<CreateOfferReply> responseObserver) {
-        TransactionResultHandler resultHandler = transaction -> {
-            CreateOfferReply reply = CreateOfferReply.newBuilder().setResult(true).build();
+        CountDownLatch latch = new CountDownLatch(1);
+        try {
+            TransactionResultHandler resultHandler = transaction -> {
+                latch.countDown();

In `GrpcOffersService`, there is a comment explaining why `OfferInfo` is used:

        // The client cannot see bisq.core.Offer or its fromProto method.
        // We use the lighter weight OfferInfo proto wrapper instead, containing just
        // enough fields to view and create offers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4558#discussion_r495198825
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200925/b4574fdb/attachment.html>


More information about the bisq-github mailing list