[bisq-network/bisq] Revert "Deactive confirm buttons once mediation started" (#4562)

[chimp1984]

We want to achieve 2 goals. 
1. We want to avoid that a fiat seller delays payout just before arbitration can be opened without any penalty.
2. We want to avoid that penalty is rendered irrelevant as the trader can continue the trade and ignoring the mediated payout suggestion.

For point 2:
For buyers it has less relevance as it requires that the seller agrees as well by confirming, so in conflict the seller has no incentive to do that (he would also gain from penalty as he receives that part) and if he agrees he basically "forgive" the buyer for some protocol violation. This might still be an issue as those protcol violations might not only hurt the other peer but could cause a more general problem to Bisq (e.g. attracting scammers if they get away easily), but I think that can be ignored. For the sellers side we have covered the fiat seller with point 1 and the altcoin seller does not gain anything from delaying the confirmation, in the opposite he is also interested to get his deposit unlocked, so I think we can also ignore that case.

So point 1 is the remaining problem we want to solve.
If we allow for fiat seller confirming while mediation is open he might try to delay the mediation result as long as possible. Same if we allow after mediation is closed we would need some tolerance time, say 1 day until he still can confirm but that would also render any penalty applied by mediators to have no consequences as well creates incentive to delay mediation result. So this does not solve our problem.

My suggesting is: 
- Enable for buyer and altcoin seller at all times (only once arbitration is opened it is disabled as there is no way anyway to do a normal payout anymore.
- Disable for fiat seller while mediation is open. Enable it at dispute result if no penalty was applied by mediators (derived from payout suggestion). So the mediator is the enabler for the confirm-button by his judgement expressed in the payout suggestion. This solves automatically point 2 as if the mediated payout suggestion is the same as the happy-path there is no avoid-penalty issue as no penalty was applied. 
If seller confirms receipt in mediation the mediator can close anyway so there is only a bit of extra friction and delay due the communication but the dispute has to be closed anyway from the mediator. So I don't see that this creates any significant difference. If mediator has applied a penalty to the buyer the seller still gets his button activated (no penaly for seller - this is the only condition we check). So the seller has 2 options: accept mediated result and hope that buyer accept as well, or click confirm button and "forgive" buyer. The confirm button would stay active also after accept button has been clicked. So he can try mediated suggestion and before it goes to arbitration click the confirm button so we avoid arbitration cases.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4562#issuecomment-699670208
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200927/ed157a8a/attachment-0001.html>