[bisq-network/bisq] Use existing timer in unlockwallet(pwd, timeout) (#4558)

Stan notifications at github.com
Sun Sep 27 20:12:54 UTC 2020


@ghubstan commented on this pull request.



> @@ -86,21 +90,53 @@ public void getOffers(GetOffersRequest req,
     @Override
     public void createOffer(CreateOfferRequest req,
                             StreamObserver<CreateOfferReply> responseObserver) {
-        TransactionResultHandler resultHandler = transaction -> {
-            CreateOfferReply reply = CreateOfferReply.newBuilder().setResult(true).build();
+        CountDownLatch latch = new CountDownLatch(1);
+        try {
+            TransactionResultHandler resultHandler = transaction -> {
+                latch.countDown();

Imagine my embarrassment... but I'm still stuck.  The resultHandler passed into coreApi.createOffer has not been initialized when all is moved to the handler directly, and it cannot compile.

 BTW, this file was changed again in commit 82b7b79.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4558#discussion_r495610803
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200927/cf58fa5a/attachment.html>


More information about the bisq-github mailing list