[bisq-network/bisq] Use existing timer in unlockwallet(pwd, timeout) (#4558)

[chimp1984]

@chimp1984 commented on this pull request.



> @@ -86,21 +90,53 @@ public void getOffers(GetOffersRequest req,
     @Override
     public void createOffer(CreateOfferRequest req,
                             StreamObserver<CreateOfferReply> responseObserver) {
-        TransactionResultHandler resultHandler = transaction -> {
-            CreateOfferReply reply = CreateOfferReply.newBuilder().setResult(true).build();
+        CountDownLatch latch = new CountDownLatch(1);
+        try {
+            TransactionResultHandler resultHandler = transaction -> {
+                latch.countDown();

Ah ok. I checked out the branch now to see more closely what the problem is.
We combined the offer creation and asycn offer placing in one method. This should be changed, and then the problem in the API code is also solved.

I will post below a patch, so its easier to see it in code... I just the did the minimum, need to be done on the other offer methods as well (we should also name it more clearly to make it easier understandable why there are 2 methods. I assume one is buyOffer and one is sellOffer (have not looked more in details yet)... the old domain code will require some refactorings as well... I hope I find in a few weeks time to join in those efforts...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4558#discussion_r495619071
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200927/552b1a6a/attachment.html>