[bisq-network/bisq] [WIP] Build out 'createoffer' API method (#4559)

Stan notifications at github.com
Mon Sep 28 14:55:01 UTC 2020


@ghubstan commented on this pull request.

@chimp1984 

RE:  [Why are there are two 'Offer createOffer()' createOffer methods?](https://github.com/bisq-network/bisq/pull/4558#discussion_r495619071)

(1) is for creating a new buy-or-sell order with a random offerId
(2) is for creating a new buy-or-sell order with a given offerId
	
I think 2nd could be altered and/or renamed to use as a new 'placeoffer' method, where a cached Offer (in the single user daemon instance) created in the 1st is passed to the 2nd, after the user enters a 'placeoffer offer-id' command.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4559#pullrequestreview-497614888
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200928/6f7ac88b/attachment.html>


More information about the bisq-github mailing list