[bisq-network/bisq] Trade protocol domain improvements (#4566)

[chimp1984]

@chimp1984 commented on this pull request.



>          onTradesChanged();
 
-        getAddressEntriesForAvailableBalanceStream()
+        btcWalletService.getAddressEntriesForAvailableBalanceStream()
                 .filter(addressEntry -> addressEntry.getOfferId() != null)
                 .forEach(addressEntry -> {
                     log.warn("Swapping pending OFFER_FUNDING entries at startup. offerId={}", addressEntry.getOfferId());
                     btcWalletService.swapTradeEntryToAvailableEntry(addressEntry.getOfferId(), AddressEntry.Context.OFFER_FUNDING);

It was old code as well and I was wondering as well if its really needed. But did not want to risk to remove it or spend more time to think about the context. Not sure I can add a meaningful comment without starting to look more closely into it why it was added. I think it is a just a cleanup if address entries have not been swapped as intended in some error cases... We dont want that BitcoinJ creates too many addresses as it makes the wallet slower.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4566#discussion_r496282536
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200928/c19729cc/attachment.html>