[bisq-network/bisq] Trade protocol domain improvements (#4566)

chimp1984 notifications at github.com
Mon Sep 28 23:09:43 UTC 2020


@chimp1984 commented on this pull request.



>  
-            // Taker has to sign offerId (he cannot manipulate that - so we avoid to have a challenge protocol for passing the nonce we want to get signed)
+            // We set the taker fee only in the processModel yet not in the trade as the tx was only created but not
+            // published yet. Once it was published we move it to trade. The takerFeeTx should be sent in a later
+            // message bu that cannot be changed due backward compatibility issues. It is a left over from the

Will fix it..

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4566#discussion_r496284190
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200928/f52ea4d8/attachment-0001.html>


More information about the bisq-github mailing list